Skip to content

fix: set minimum amount for Ethereum network #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dprof-in-tech wants to merge 4 commits into from
Closed

fix: set minimum amount for Ethereum network #349

Dprof-in-tech wants to merge 4 commits into from

Conversation

@Dprof-in-tech
Copy link
Collaborator

@Dprof-in-tech Dprof-in-tech commented Jan 16, 2026 •
edited
Loading

Description

This pull request introduces a network-specific validation to the transaction form, ensuring users meet the minimum transaction amount for Ethereum.

Validation update for Ethereum transactions:

  • In TransactionForm.tsx, a $50 USD minimum is enforced when the selected network is Ethereum.

References

WE ARE ENFORCING A $50 USD MINIMUM FOR ETHEREUM

Testing

Screenshot 2026-01-16 at 12 00 04 image
  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation and tests for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

By submitting a PR, I agree to Paycrest's Contributor Code of Conduct and Contribution Guide.

@Dprof-in-tech Dprof-in-tech requested a review from chibie as a code owner January 16, 2026 11:04
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

onahprosper
onahprosper requested changes Jan 16, 2026
View reviewed changes
app/pages/TransactionForm.tsx Outdated
const errorMessage = cngnRateError || "No available quote";
setRateError(errorMessage);
}
} else if (selectedNetwork?.chain?.name === "Ethereum") {
Copy link
Collaborator

@onahprosper onahprosper Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dprof-in-tech if (selectedNetwork?.chain?.name === "Ethereum") and (normalizedToken === "CNGN"), this still assumes that the minimum will be 50 for CNGN and other respective local currencies.
Within this if block, let's add a check for when the selected token is CNGN

@sundayonah
Copy link
Collaborator

sundayonah commented Jan 16, 2026

kindly check for balance first.
an address with 0$ the error message should be Insufficient balance.

@Dprof-in-tech
Copy link
Collaborator Author

Dprof-in-tech commented Jan 16, 2026

kindly check for balance first. an address with 0$ the error message should be Insufficient balance.

balance check follows existing method where we check is it above the minimum transaction amount? then we check if its below your balance

@chibie chibie changed the title fix: set minimum amount for Ethereum network to $50 USD in TransactionForm fix: set minimum amount for Ethereum network Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@onahprosper onahprosper onahprosper requested changes

@chibie chibie Awaiting requested review from chibie chibie is a code owner

@5ran6 5ran6 Awaiting requested review from 5ran6

@sundayonah sundayonah Awaiting requested review from sundayonah

@SarahSync SarahSync Awaiting requested review from SarahSync

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dprof-in-tech @sundayonah @onahprosper